[libcxx-commits] [PATCH] D151260: [Demangle] avoid more std::string_view::substr

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: libcxxabi/src/demangle/StringViewExtras.h:30
+                        std::string_view needle) noexcept {
+  if (needle.empty())
+    return true;
----------------
`if (needle.empty())` is a special case that can be handled by the generic code. It can be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151260/new/

https://reviews.llvm.org/D151260