[libcxx-commits] [PATCH] D151265: [libc++] Introduce __for_each_segment and use it in copy/move

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This is a nice refactoring! LGTM w/ green CI.



================
Comment at: libcxx/include/__algorithm/for_each_segment.h:21
+
+template <class _SegmentedIterator, class _Functor>
+_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX14 void
----------------
Can you please document what this function does in a comment?


================
Comment at: libcxx/include/__algorithm/for_each_segment.h:29
+
+  // We are in a single segment, so we might not be at the begin or end
+  if (__sfirst == __slast) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151265/new/

https://reviews.llvm.org/D151265