[libcxx-commits] [PATCH] D148693: [libc++] Set correct size at the end of growing std::string

Tacet via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 24 01:23:27 PDT 2023


AdvenamTacet updated this revision to Diff 525058.
AdvenamTacet marked 7 inline comments as done.
AdvenamTacet added a comment.

This update fixes issues mentioned in the code review:

- adds `_LIBCPP_DEPRECATED_("use __grow_by_without_replace")`,
- adds `_LIBCPP_HIDE_FROM_ABI_AFTER_V1`,
- changes deprecated call to `__grow_by` in `__grow_by_without_replace` with a copy-paste code of the function.
- in `libcxx/include/__string/extern_template_lists.h` removes references to `__grow_by` and `__grow_by_without_replace`,
- clang-format, I hope this time I used the correct config!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148693/new/

https://reviews.llvm.org/D148693

Files:
  libcxx/include/__string/extern_template_lists.h
  libcxx/include/string
  libcxx/lib/abi/arm64-apple-darwin.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/powerpc-ibm-aix.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/powerpc64-ibm-aix.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/x86_64-apple-darwin.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/x86_64-unknown-freebsd.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.noexceptions.nonew.abilist

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148693.525058.patch
Type: text/x-patch
Size: 25442 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230524/b64c8bb0/attachment-0001.bin>


More information about the libcxx-commits mailing list