[libcxx-commits] [PATCH] D150896: [libc++] Apply _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION only in classes that we have instantiated externally

Wed May 24 01:20:57 PDT 2023

gribozavr2 added a comment.

In D150896#4366698 <https://reviews.llvm.org/D150896#4366698>, @philnik wrote:

> In D150896#4366612 <https://reviews.llvm.org/D150896#4366612>, @gribozavr2 wrote:
>
>> In D150896#4366406 <https://reviews.llvm.org/D150896#4366406>, @philnik wrote:
>>
>>> Do you possibly have an explicit instantiation of `__gnu_cxx::hash_map<std::string>`? That would break things with this patch, and is most likely not supported.
>>
>> Thanks for looking into this! Why would such a use case be unsupported?
>
> http://eel.is/c++draft/requirements#namespace.std-5

Sure, but imagine we copy `__gnu_cxx::hash_map` and rename it to `gnu_cxx::hash_map`. It would break in the same way, but now it is 100% user-written code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150896/new/

https://reviews.llvm.org/D150896