[libcxx-commits] [PATCH] D151205: [libc++][spaceship] Additional tests for `operator<=>` `map` and `multimap`

Hristo Hristov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 23 14:22:59 PDT 2023


H-G-Hristov added a comment.

In D151205#4366003 <https://reviews.llvm.org/D151205#4366003>, @philnik wrote:

> In D151205#4365999 <https://reviews.llvm.org/D151205#4365999>, @H-G-Hristov wrote:
>
>> In D151205#4365640 <https://reviews.llvm.org/D151205#4365640>, @philnik wrote:
>>
>>> In D151205#4364787 <https://reviews.llvm.org/D151205#4364787>, @H-G-Hristov wrote:
>>>
>>>> Try to fix CI: Ignore `expected-error` message with `{{}}` syntax due to differing error message locally vs remotely (on CI).
>>>
>>> You probably want to update your local compiler then. We only support Clang 15, 16 and trunk.
>>
>> My local compiler is Apple Clang 14.0.3 which is based on Clang 15, which is the latest from Apple.
>
> What is the difference in error messages then? Can you check the actual message with a regex maybe? (`// expected-error-re {{... {{regex}} ...}}`)

I just updated this test with the `//expected-error-re {{... {{regex}} }} syntax now. Apple Clang  outputs "static_assert" vs "static assertion" on the CI. I've seen a patch that you want to remove this syntax. Then I guess may need to revert this change and figure out how to setup a non-Apple compiler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151205/new/

https://reviews.llvm.org/D151205



More information about the libcxx-commits mailing list