[libcxx-commits] [PATCH] D151205: [libc++][spaceship] Additional tests for `operator<=>` `map` and `multimap`

[Hristo Hristov via Phabricator via libcxx-commits]

H-G-Hristov added inline comments.


================
Comment at: libcxx/test/std/containers/associative/map/map.nonmember/compare.three_way.verify.cpp:21
+
+#include "test_allocator.h"
+
----------------
philnik wrote:
> This include doesn't seem to be used,
It is used for the last test.


================
Comment at: libcxx/test/std/containers/associative/map/map.nonmember/compare.three_way.verify.cpp:28
+    std::map<int, int, std::greater<int>> s2;
+    // expected-error@*:* 2 {{invalid operands to binary expression}}
+    s1 <=> s2;
----------------
philnik wrote:
> IMO it would be better to have two separate `// expected-error`s to make sure they are actually generated by the two lines below.
Thanks! That makes sense. I'll update my tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151205/new/

https://reviews.llvm.org/D151205