[libcxx-commits] [PATCH] D150802: [libc++][format] Removes the experimental status.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a subscriber: philnik.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM w/ comments.

Thanks a lot for all the work you've put into taking `std::format` from nothing to a stable feature, this is awesome!



================
Comment at: libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp:26-28
 #ifdef _LIBCPP_HAS_NO_INCOMPLETE_FORMAT
 #   error "-fexperimental-library should enable <format>"
 #endif
----------------
This should be removed in this patch.


================
Comment at: libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp:30
+
+// TODO What to do with this file it seems not to be generated.
----------------
Mordante wrote:
> @ldionne you added this file, do we want to keep it? If so we probably need to generated something. I don't think there is a similar PSTL test.
@philnik We should add a test for the PSTL here, that's an oversight. This would make sure that the PSTL is indeed enabled when we pass `-fexperimental-library`.

Then it makes sense to remove `_LIBCPP_HAS_NO_INCOMPLETE_FORMAT` and this test still has a purpose. I think that we are likely to have at least one experimental feature in flight at all times, so this test would stay relevant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150802/new/

https://reviews.llvm.org/D150802