[libcxx-commits] [PATCH] D150538: [libc++] Untangles invoke.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Just to expand on why this is important, Mark just explained to me that it allowed the test in https://reviews.llvm.org/D144994 (`libcxx/test/tools/clang_tidy_checks/header_exportable_declarations.cpp`) to check that we export the right declarations from `type_traits.cppm`. If `is_invocable` isn't declared under `__type_traits/`, it has to be added to the ignore list for that test and we want to minimize that. I think we should make this change cause it gets us closer to having a systematic way of determining where the declaration of an entity should live, which comes up from time to time when it's not 100% clear.



================
Comment at: libcxx/utils/data/ignore_format.txt:643
 libcxx/include/typeinfo
+libcxx/include/type_traits
 libcxx/include/__type_traits/add_const.h
----------------
Mordante wrote:
> Note sure why this is needed, locally no formatting changes can be done.
This is probably related to the recent clang-format issues. It would be nice to avoid adding this file to the ignore list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150538/new/

https://reviews.llvm.org/D150538