[libcxx-commits] [PATCH] D151026: [libc++] Adds C++26 support.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/utils/data/ignore_format.txt:253
 libcxx/include/__chrono/month_weekday.h
+libcxx/include/__chrono/statically_widen.h
 libcxx/include/__chrono/steady_clock.h
----------------
Mordante wrote:
> Not sure why this file changed, but this makes the CI happy.
I think this should be gone when you rebase.


================
Comment at: libcxx/utils/libcxx/test/params.py:65
     'c++23': 'c++2b',
+    'c++26': 'c++2c',
   }
----------------
Mordante wrote:
> philnik wrote:
> > Is this required, since both GCC and Clang support the `c++26` flag right away?
> Fair point, probably not. I think we could even remove 0x, 1y. 1z, and 2a. Since we don't support that ancient compilers.
> 
> AFAIK there is no gcc yet that support C++26, but as @jwakely indicated it's expected that GCC will support C++26 and C++2c at the same time.
I think we should indeed remove the fallbacks here (in a separate patch). I don't think they are needed anymore, except the c++23 and c++26.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151026/new/

https://reviews.llvm.org/D151026