[libcxx-commits] [PATCH] D148566: [libcxxabi] copy back std::string_view patches from LLVM

Mon May 22 14:58:18 PDT 2023

nickdesaulniers added a comment.

In D148566#4362478 <https://reviews.llvm.org/D148566#4362478>, @nickdesaulniers wrote:

> In D148566#4362390 <https://reviews.llvm.org/D148566#4362390>, @nickdesaulniers wrote:
>
>> I can build DemangleTests just fine, though I do set `-DLLVM_ENABLE_LLD=ON` to link with LLD rather than BFD. Let me try BFD.
>>
>> (Shows that I was able to link via ld.bfd successfully) I wonder what else could be going wrong for this particular presubmit? `_LIBCPP_VERBOSE_ABORT` is not set AFAICT.
>
> Ah, it's `check-cxxabi` ninja target that's failing to build (w/ gcc and bfd). I can repro now. Digging (this seems related to `_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS`).

https://reviews.llvm.org/D151160

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148566/new/

https://reviews.llvm.org/D148566