[libcxx-commits] [PATCH] D151046: [libcxx][tests] Introduce 32-bit feature and use it for stringstream gcount test

[Michał Górny via Phabricator via libcxx-commits]

mgorny added inline comments.


================
Comment at: libcxx/test/std/input.output/string.streams/stringstream.members/gcount.pass.cpp:9
 
-// All 32 bit arches that CI has:
-//
-// UNSUPPORTED: target=powerpc-ibm-aix
-// UNSUPPORTED: target={{.*}}armv7l{{.*}}
-// UNSUPPORTED: target={{.*}}armv8l{{.*}}
-// UNSUPPORTED: target=i686-w64-windows-gnu
+// UNSUPPORTED: 32-bit-architecture
 
----------------
Well, I don't want to be picky but if you want to use a long name anyway, than perhaps something like "32-bit-pointer" would be more precise. After all, I dare say n32 ABI is also using 32-bit pointers but it's works only on a 64-bit CPU architecture.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151046/new/

https://reviews.llvm.org/D151046