[libcxx-commits] [PATCH] D151030: [libc++][modules] Adds std module cppm files.

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added a comment.

I just took a look at it and it looks almost fine. I can't be sure if there is anything missing. But it may be better to decide this by testing instead of by eyes. So this looks good to me.



================
Comment at: libcxx/modules/std/vector.cppm:20
+  using std::operator==;
+#if 0 // P1614
+  using std::operator<=>;
----------------
It looks better if we can use meaningful name like `#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151030/new/

https://reviews.llvm.org/D151030