[libcxx-commits] [PATCH] D146294: [libcxx] Fix crash in std::stringstream with payload >= INT_MAX

[Azat Khuzhin via Phabricator via libcxx-commits]

azat added a comment.

In D146294#4358993 <https://reviews.llvm.org/D146294#4358993>, @mgorny wrote:

> Other options could be:
>
> - using regexps to grab wider range of targets (e.g. `i.86-.*`, `arm.*`, `powerpc-.*` and so on),

It doesn't sounds generic to me.

> - doing a `if (sizeof(void*) < 8) return 0` or alike in the test.

I had sizeof before, but there was concerns that it is unclear when the test runs and when it is not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146294/new/

https://reviews.llvm.org/D146294