[libcxx-commits] [PATCH] D146294: [libcxx] Fix crash in std::stringstream with payload >= INT_MAX

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D146294#4358807 <https://reviews.llvm.org/D146294#4358807>, @azat wrote:

> In D146294#4358805 <https://reviews.llvm.org/D146294#4358805>, @Mordante wrote:
>
>> @ldionne I really feel we should implement my original suggestion where we test whether the platform under test is a 32-bit platform and disable the test based on that result
>
> FWIW here is my initial patch for this - https://github.com/azat-archive/llvm-project/commit/56ab528e03fc9cba25d4f9944f38f159ec162f88

I talked with @ldionne about making changes to the bridge before (unrelated to this patch) and he convinced me that's not a great idea. There are good reasons to have as little in bridge as possible. However I think we can fix this by changing `libcxx/utils/libcxx/test/features.py`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146294/new/

https://reviews.llvm.org/D146294