[libcxx-commits] [PATCH] D144362: [libcxx] <experimental/simd> Add ABI tags, class template simd/simd_mask implementations. Add related simd traits and tests.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nits. (and sorry for being so slow in reviewing this)



================
Comment at: libcxx/test/std/experimental/simd/simd.traits/is_abi_tag.pass.cpp:55
+void test_simd_abi() {
+  if constexpr (std::is_same<F, CheckIsAbiTagTrue>::value) {
+    F{}.template operator()<ex::is_abi_tag<SimdAbi>>();
----------------



================
Comment at: libcxx/test/std/experimental/simd/simd.traits/is_abi_tag.pass.cpp:56
+  if constexpr (std::is_same<F, CheckIsAbiTagTrue>::value) {
+    F{}.template operator()<ex::is_abi_tag<SimdAbi>>();
+  } else if constexpr (std::is_same<F, CheckIsAbiTagFalse>::value) {
----------------
Couldn't the `static_assert`s be inlined here? The `CheckIsAbiTag*` could simply be tag types.


================
Comment at: libcxx/test/std/experimental/simd/test_utils.h:35
+void test_fixed_size_deduce_t(std::integer_sequence<std::size_t, _Np...>) {
+  using namespace ex;
+
----------------
This doesn't really seem with it given that it already just `ex`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144362/new/

https://reviews.llvm.org/D144362