[libcxx-commits] [PATCH] D150322: [NFC] Move __CORRECT_ISO_CPP_WCHAR_H_PROTO closer to wchar.h include
Jordan Rupprecht via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri May 19 15:35:26 PDT 2023
rupprecht added a comment.
In D150322#4356560 <https://reviews.llvm.org/D150322#4356560>, @Mordante wrote:
> In D150322#4354896 <https://reviews.llvm.org/D150322#4354896>, @rupprecht wrote:
>
>> I forgot about this patch but I won't be around to watch it go through buildbots etc., so I'll plan to land it as soon as I get back in a couple weeks.
>
> Does this main the breakage of D150015 <https://reviews.llvm.org/D150015> will remain for a couple of weeks. If so I think we should revert D150015 <https://reviews.llvm.org/D150015> and look at a good solution for you when you're back. WDYT?
No, this change itself should be NFC. D150015 <https://reviews.llvm.org/D150015> is a fix for D148542 <https://reviews.llvm.org/D148542>. So please don't revert D150015 <https://reviews.llvm.org/D150015>, unless it's part of also reverting D148542 <https://reviews.llvm.org/D148542> if you choose to do that for https://github.com/llvm/llvm-project/issues/62523.
D148542 <https://reviews.llvm.org/D148542> looks like a bug fix for something else, so I don't know if it's a good idea to revert. Check with @iana I guess?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150322/new/
https://reviews.llvm.org/D150322
More information about the libcxx-commits
mailing list