[libcxx-commits] [PATCH] D150908: [libc++][ci] Use ccache in the jobs that build Clang

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 19 08:56:51 PDT 2023


Mordante added a comment.

In D150908#4356632 <https://reviews.llvm.org/D150908#4356632>, @philnik wrote:

> In D150908#4356524 <https://reviews.llvm.org/D150908#4356524>, @Mordante wrote:
>
>> When the cache is preserved between runs we might want to do the same for libc++.
>
> I don't think that makes a lot of sense. The libc++ build takes only a few seconds and (unfortunately) relies on large parts of our headers, which change with pretty much every patch, making it probably not very profitable. Also, while it's not a big problem, it does add another point of failure to the build. It's most likely worth the small risk for clang builds, but I't not convinced it is for libc++ builds.

I don't recall the last time I had issues with ccache. But as said we "might want to" consider it so we need to measure. I've no idea how much time the runners spend on building libc++. This is the same for a lot of runners since we always build it with C++20. Also not all headers are always touched.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150908/new/

https://reviews.llvm.org/D150908



More information about the libcxx-commits mailing list