[libcxx-commits] [PATCH] D150322: [NFC] Move __CORRECT_ISO_CPP_WCHAR_H_PROTO closer to wchar.h include

Thu May 18 17:12:32 PDT 2023

rupprecht added a comment.

I forgot about this patch but I won't be around to watch it go through buildbots etc., so I'll plan to land it as soon as I get back in a couple weeks.

In D150322#4333650 <https://reviews.llvm.org/D150322#4333650>, @iana wrote:

> Either way is fine with me. I didn't think about wchar.h, maybe better to leave that one the way it is to be on the safe side, and leave __mbstate_t.h the way you have it already for consistency.

I guess I also don't have a preference either way, but I think consistency is important -- trying to reason whether `__CORRECT_ISO_CPP_WCHAR_H_PROTO` affects one place but not the other is just real estate I don't want my brain to spend time on.

In D150322#4352194 <https://reviews.llvm.org/D150322#4352194>, @sylvestre.ledru wrote:

> fyi, it doesn't fix
> https://github.com/llvm/llvm-project/issues/62523

I wouldn't expect it to. At least in the sources I'm looking at, `__CORRECT_ISO_CPP_WCHAR_H_PROTO` should only affect the function signatures of `wcschr`, `wcsrchr`, `wcspbrk`, and `wcsstr`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150322/new/

https://reviews.llvm.org/D150322