[libcxx-commits] [PATCH] D150897: [runtimes] Use libunwind from libc++ and libc++abi by default

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay accepted this revision.
MaskRay added a comment.

LGTM from #libunwind <https://reviews.llvm.org/tag/libunwind/> side.

On Linux, both `libgcc_s.so.1`/`libgcc_eh.a` and `libunwind.so`/`libunwind.a` are popular. Considering also BSD, I think the majority of libc++ users have switched to using llvm-project/libunwind primarily, so this default switch makes a lot of sense.

The "Level 1: Base ABI of Itanium C++ ABI: Exception Handling" part of libunwind is very stable, so I don't worry too much that doing this change will degrade `libgcc_s.so.1`/`libgcc_eh.a` compatibility in the long run.
Having a `LIBCXXABI_USE_LLVM_UNWINDER=ON` build bot will definitely be great, but I am fine we don't have it due to resource limitation/etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150897/new/

https://reviews.llvm.org/D150897