[libcxx-commits] [PATCH] D150476: [libc++] Run headers_declare_verbose_abort.sh.cpp in parallel

Thu May 18 10:19:23 PDT 2023

Mordante added a comment.

In D150476#4347362 <https://reviews.llvm.org/D150476#4347362>, @ldionne wrote:

> In D150476#4343321 <https://reviews.llvm.org/D150476#4343321>, @philnik wrote:
>
>> In D150476#4343308 <https://reviews.llvm.org/D150476#4343308>, @Mordante wrote:
>>
>>> Please let's not do this. I mentioned that this was troublesome in https://reviews.llvm.org/D144640#inline-1408386. I really would appreciate to have that test fixed too.
>>>
>>> I use lit to do determine how many jobs to start and now these tests start to spam extra jobs. I'm not against fixing this issue, but basically deciding for users that they can spawn 16 extra parallel jobs really sounds wrong to me. This has lead me a few times to an unresponsive system since I had other heavy tasks running in parallel.
>>
>> I don't plan to land this as-is. This was only to test how much the modules build can be improved, and I published it to remember to talk with Louis about this.
>
> Just recording what we discussed as a potential direction: have a Lit test format that allows generating arbitrary Lit tests (e.g. it generates JSON or Pickled `Lit.Test` objects) and adds it to the test suite. Maybe this needs to be hooked into `getTestsInDirectory`?

I really like that idea. Then the scheduling the tests is done by lit again and we can easily "split" these large tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150476/new/

https://reviews.llvm.org/D150476