[libcxx-commits] [PATCH] D150493: [libc++] Add functions that ensure a given iterator meets the syntactic requirements

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/CMakeLists.txt:417
   __fwd/string_view.h
   __fwd/subrange.h
   __fwd/tuple.h
----------------
Commit message: `Add functions` -- those are not functions anymore.


================
Comment at: libcxx/include/__iterator/cpp17_iterator_concepts.h:158
+#  ifndef _LIBCPP_DISABLE_ITERATOR_CHECKS
+#    define _LIBCPP_REQUIRE_INPUT_ITERATOR(iter_t) static_assert(::std::__cpp17_input_iterator<iter_t>);
+#    define _LIBCPP_REQUIRE_OUTPUT_ITERATOR(iter_t, write_t)                                                           \
----------------
And throughout?


================
Comment at: libcxx/test/libcxx/algorithms/cpp17_iterator_concepts.verify.cpp:9
+
+// Check that __check_*_iterator_requirements catch bad iterators
+
----------------
This comment needs to be updated.


================
Comment at: libcxx/test/libcxx/algorithms/cpp17_iterator_concepts.verify.cpp:11
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+
----------------
You're not testing bidirectional and random access.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150493/new/

https://reviews.llvm.org/D150493