[libcxx-commits] [PATCH] D150801: [libc++][NFC] Rename iterator category checks to make it obvious that they check //only// the iterator category

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 18 09:31:12 PDT 2023


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ comment.



================
Comment at: libcxx/include/__iterator/iterator_traits.h:476
 template <class _Tp>
 struct __is_cpp17_contiguous_iterator : _Or<
     __has_iterator_category_convertible_to<_Tp, contiguous_iterator_tag>,
----------------
Maybe `__libcpp_is_contiguous_iterator` instead? It doesn't imply anything about C++17 or whether we check for a specific category/concept.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150801/new/

https://reviews.llvm.org/D150801



More information about the libcxx-commits mailing list