[libcxx-commits] [PATCH] D144734: [libcxx] Enable support for static and debug Windows runtimes

Wed May 17 14:38:16 PDT 2023

mstorsjo added a comment.

In D144734#4349737 <https://reviews.llvm.org/D144734#4349737>, @andrewng wrote:

> In D144734#4347261 <https://reviews.llvm.org/D144734#4347261>, @mstorsjo wrote:
>
>> FYI, the project minimum CMake version has more been bumped to 3.20, so this can be updated to only use `CMAKE_MSVC_RUNTIME_LIBRARY` now.
>
> I already did this sometime ago, just waiting and waiting for things to settle. However, I may try updating the patch to check the situation with regards to `libc++` CI.

Thanks! Things seem to take some time to settle though, as the CMake bump patch got reverted now.

Additionally, with https://reviews.llvm.org/D150688 it looks like we might end up sticking with the old way of picking CRT for some time still; primarily for other parts of llvm, but it might end up having to apply to libcxx too...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144734/new/

https://reviews.llvm.org/D144734