[libcxx-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mike Hommey via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 17 13:29:44 PDT 2023


glandium added a comment.

In D144509#4349051 <https://reviews.llvm.org/D144509#4349051>, @hans wrote:

> In D144509#4347562 <https://reviews.llvm.org/D144509#4347562>, @glandium wrote:
>
>> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c <https://reviews.llvm.org/rG65429b9af6a2c99d340ab2dcddd41dab201f399c> is causing problems on Windows compiler-rt for some reason I haven't identified yet (with cmake 3.25.1). Which suggests for a same version of cmake, this is actually altering its behavior, which I wouldn't have expected...
>
> It is indeed unfortunate that this seems to come with such a fundamental behavior change. (we already have https://github.com/llvm/llvm-project/issues/62719) Do you have a repro for the issue you're seeing?

The Chromium issue that is discussed there is essentially the same thing I was seeing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509



More information about the libcxx-commits mailing list