[libcxx-commits] [PATCH] D150766: [libcxx] [ci] Add a test configuration with an incomplete sysroot

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:675-676
+          -DCMAKE_CXX_COMPILER=x86_64-w64-mingw32-clang++ \
+          -DCMAKE_C_FLAGS_INIT="--sysroot=${BUILD_DIR}/sysroot" \
+          -DCMAKE_CXX_FLAGS_INIT="--sysroot=${BUILD_DIR}/sysroot" \
+          -DCMAKE_C_COMPILER_WORKS=TRUE \
----------------
Can you use `CMAKE_SYSROOT`?


================
Comment at: libcxx/utils/ci/run-buildbot:679
+          -DCMAKE_CXX_COMPILER_WORKS=TRUE \
+          -DCMAKE_CXX_COMPILER_TARGET=x86_64-w64-windows-gnu \
+          -C "${MONOREPO_ROOT}/libcxx/cmake/caches/MinGW.cmake"
----------------
I'd set `CMAKE_C_COMPILER_TARGET` as well for consistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150766/new/

https://reviews.llvm.org/D150766