[libcxx-commits] [PATCH] D144322: [libc++][Modules] Make top level modules for all C++ headers with OS/clang versions

[Duncan P. N. Exon Smith via Phabricator via libcxx-commits]

dexonsmith added a comment.

In D144322#4344301 <https://reviews.llvm.org/D144322#4344301>, @iana wrote:

> If you want to ignore all the added includes and review the rest, it should be in a good state. I'm temporarily using this review to test for more missing includes via CI. I guess my local environment is different enough that it didn't find all of them.

I wonder if it'd be easy to look at the log from the bot that's failing, and use that CMake configuration locally to find these with a faster turnaround. For example, a lot of the fixes seem to be in `libcxx/include/pstl/`; perhaps there's a configuration to turn on (more of?) the PSTL locally.

Also, in case you didn't know, there's a way to link two reviews together in Phabricator: in the top-right, "Edit Related Revisions". You could put these include fixes in a "parent" revision (or in a bunch of parent revisions), keeping this review clean, and manually trigger a new bot run / rebase each time you update the parent with more fixes (or add a parent).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144322/new/

https://reviews.llvm.org/D144322