[libcxx-commits] [PATCH] D150784: [NFC][Py Reformat] Reformat python files in the rest of the dirs

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 17 09:38:59 PDT 2023


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks for working on this! LGTM!

Note libc++ has more python files like `libcxx/utils/generate_header_inclusion_tests.py` are these intended to be reformatted too.
If so I really prefer to postpone these files. I have some patches for them and I would prefer to avoid merge conflicts.

Another question is it intended to validate the formatting? For libc++ we validate the formatting of our C++ code in the pre-commit CI. I really think it would be great to do that for these files too. If wanted I can do that too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150784/new/

https://reviews.llvm.org/D150784



More information about the libcxx-commits mailing list