[libcxx-commits] [PATCH] D150284: [libc++][PSTL] Add a simple std::thread backend

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D150284#4350281 <https://reviews.llvm.org/D150284#4350281>, @EricWF wrote:

> In D150284#4347476 <https://reviews.llvm.org/D150284#4347476>, @philnik wrote:
>
>> In D150284#4347301 <https://reviews.llvm.org/D150284#4347301>, @EricWF wrote:
>>
>>> The `__threading` header, which defines a stable API that libc++ uses to implement threading primitives. This has been used by a bunch of vendors to shim in the different implementations for their platforms.
>>> I believe we'll want to do the same thing here.
>>>
>>> Do we know what the full API will look like yet?
>>
>> We don't know exactly which parts we will require, but I don't think that's relevant for this patch. We only implement a single (primitive) backend here, which will most likely not exist for a long time in this form.
>
> I'm a bit worried about shipping these patches then. I normally prefer to have a bunch more certainty when committing stuff to non-experimental bits of the library. @ldionne, you're cool with this plan?

This part of the library //is// experimental?

> When will we know what we need?
> When will the API be stable?
>
> Because providing an API for vendors here is going to be important.

I don't know exactly what you mean by "here". Do you mean as part of the std::thread backend? If yes, I very much disagree. This is already layer two of abstractions which vendors can customize. Adding a third one would just be absurd.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150284/new/

https://reviews.llvm.org/D150284