[libcxx-commits] [PATCH] D144734: [libcxx] Enable support for static and debug Windows runtimes

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D144734#4347261 <https://reviews.llvm.org/D144734#4347261>, @mstorsjo wrote:

> FYI, the project minimum CMake version has more been bumped to 3.20, so this can be updated to only use `CMAKE_MSVC_RUNTIME_LIBRARY` now.

Actually, libcxx seems to include `ChooseMSVCCRT.cmake` still, which expects the old style of setting the option, so this thing hasn't really settled yet. See https://reviews.llvm.org/D150688 for updates on that topic. WRT this patch, it's probably best to hold off for another couple weeks to see how these things settle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144734/new/

https://reviews.llvm.org/D144734