[libcxx-commits] [PATCH] D150747: [libc++][ranges] Add benchmarks for the `from_range` constructors of `vector` and `deque`.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 16 22:59:16 PDT 2023


Mordante added a comment.

I would prefer to have the CMake changes in a separate patch. I'm happy with these changes after applying my suggestion.



================
Comment at: libcxx/benchmarks/CMakeLists.txt:1-5
-if (CMAKE_VERSION VERSION_LESS 3.17)
+if (CMAKE_VERSION VERSION_LESS 3.20)
   message(WARNING "The libc++ benchmarks won't be available because the version of CMake is too old to support them.")
   return()
 endif()
 
----------------
It seems I missed this hunk when I updated the CMake requirements. This version is now validated by the top-level script.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150747/new/

https://reviews.llvm.org/D150747



More information about the libcxx-commits mailing list