[libcxx-commits] [PATCH] D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Tue May 16 10:41:34 PDT 2023

yronglin marked an inline comment as done.
yronglin added inline comments.

================
Comment at: libcxx/test/libcxx/utilities/expected/expected.expected/transform_error.mandates.verify.cpp:11
+
+// ADDITIONAL_COMPILE_FLAGS: -Xclang -verify-ignore-unexpected=note
+
----------------
philnik wrote:
> yronglin wrote:
> > yronglin wrote:
> > > philnik wrote:
> > > > notes should normally be ignored. No need to specify this here.
> > > Remove `-verify-ignore-unexpected=note`
> > When I remove this flag, the command returned an error:
> > ```
> > ld: file too small (length=0) file '/var/folders/pv/yzhm_ln121n085_jxzz652y80000gn/T/transform_error-b24073.o' for architecture arm64
> > clang++: error: linker command failed with exit code 1 (use -v to see invocation)
> > ```
> This line shouldn't be required at all. The `.verify` already lets clang run in verify mode. It's probably confused because of the extra arguments.
Thanks, removed!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140911/new/

https://reviews.llvm.org/D140911