[libcxx-commits] [PATCH] D150691: [runtimes] Refactor Symbol Checking Tool

Michael Francis via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 16 10:04:16 PDT 2023


francii added inline comments.


================
Comment at: runtimes/utils/sym_check/extract.py:9
+import magic
+import yaml
+from ToolOutput import ToolOutput
----------------
`magic` and `yaml` are external modules. While we can likely get away without `magic`, since `llvm-ifs` requires us to output to a YAML file, I think it's best to read said file with `yaml.safe_load()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150691/new/

https://reviews.llvm.org/D150691



More information about the libcxx-commits mailing list