[libcxx-commits] [PATCH] D147089: [libc++] Add assertions for potential OOB reads in std::sort

[Alexander Kornienko via Phabricator via libcxx-commits]

alexfh added a comment.

Hi Louis, we've started seeing compilation errors in code using custom iterators after this patch:

  .../include/c++/v1/__algorithm/sort.h:681:14 no viable overloaded '='
      *__begin = _Ops::__iter_move(__pivot_pos);

One example that relies on an open-source library is here https://gcc.godbolt.org/z/be7xMhcn3, but we have other instances as well. Is this a intended effect of this patch? If so, can we have an escape hatch?

FWIW, the error doesn't depend on whether `_LIBCPP_ENABLE_ASSERTIONS` is enabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147089/new/

https://reviews.llvm.org/D147089