[libcxx-commits] [PATCH] D150300: [libc++][WIP] Try disabling transitive includes in all configurations to see impact on CI times

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 15 13:13:50 PDT 2023


ldionne added a comment.

In D150300#4343062 <https://reviews.llvm.org/D150300#4343062>, @Mordante wrote:

> I think we should adjust `transitive_includes.sh.cpp` test to make sure it undefines `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES` and allow it to run with `enable_transitive_includes` disabled. That should be fairly simple.

I just removed the `transitive-includes-disabled` feature and it seemed to work out of the box (which is weird).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150300/new/

https://reviews.llvm.org/D150300



More information about the libcxx-commits mailing list