[libcxx-commits] [PATCH] D150585: [libc++][doc] Updates the tasks to do for a release.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a subscriber: tstellar.
ldionne added a comment.

Thanks for working on this!



================
Comment at: libcxx/docs/ReleaseProcedure.rst:33
+  Typically the Unicode Consortium has one release per year. The libc++
+  format library uses the Unicode. Libc++ should be updated to the latest
+  Unicode version. Updating means using the latest data files and, if needed,
----------------



================
Comment at: libcxx/docs/ReleaseProcedure.rst:42
+
+After branching for an LLVM release:
+
----------------
If we have annotations like `LLVM RELEASE bump`, does it make sense to carry that list around? Duplicating the information IMO is going to create confusion and they'll get out of sync, so I think we should pick one.

CC @tstellar 


================
Comment at: libcxx/docs/ReleaseProcedure.rst:71
+- Search for test that have ``UNSUPPORTED`` or ``XFAIL`` for the no longer supported version
+- Remove the things listed for removal
+
----------------
philnik wrote:
> Could we also define a single `TODO LLVM xy` style to make it easier to grep for that?
I like that! So the documentation could say "Search for `TODO(LLVM-<version>)`" maybe? I don't care about how it's spelled, but we could document it right here and start doing it right away.


================
Comment at: libcxx/docs/ReleaseProcedure.rst:87-94
+* The base template for ``std::char_traits`` has been marked as deprecated and
+  will be removed in LLVM 18. If you are using ``std::char_traits`` with types
+  other than ``char``, ``wchar_t``, ``char8_t``, ``char16_t``, ``char32_t`` or
+  a custom character type for which you specialized ``std::char_traits``, your code
+  will stop working when we remove the base template. The Standard does not
+  mandate that a base template is provided, and such a base template is bound
+  to be incorrect for some types, which could currently cause unexpected
----------------
philnik wrote:
> Mordante wrote:
> > philnik wrote:
> > > Where is this coming from?
> > https://releases.llvm.org/16.0.0/projects/libcxx/docs/ReleaseNotes.html#deprecations-and-removals
> Could you re-add this to the release notes?
Instead, I think what we should do here is have version-specific release notes and keep the latest N versions in the repo (probably N = 1). That would actually solve other problems as well, such as merge conflicts during the early branching when we cherry-pick stuff to the release branch.

Then we could easily obtain this information without having to copy-paste anything, which is going to be error-prone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150585/new/

https://reviews.llvm.org/D150585