[libcxx-commits] [PATCH] D132092: [2a/3][ASan][libcxx] std::deque annotations

[Tacet via Phabricator via libcxx-commits]

AdvenamTacet added a comment.

I have a hard time trying to create a stand alone test.
To go to the problematic if branch, `push_back` should be called when:

- `__back_spare() == 0`
- `__front_spare() < __block_size`
- `__map_.size() < __map_.capacity()`
- `__map_.__back_spare() == 0`

The problem is incorrect value argument to a helper function `__annotate_whole_block`, but actually there is no need to call this function yet (it can be called later after whole if-else block). It's easy to see what is wrong and how to fix it. I have a hard time creating a unit test covering it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132092/new/

https://reviews.llvm.org/D132092