[libcxx-commits] [PATCH] D148641: [libc++] Add C++20 stringstream::view()

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM modulo one tiny remark. I leave the final approval to @philnik since he also had comments.



================
Comment at: libcxx/test/std/input.output/string.streams/istringstream/istringstream.members/view.pass.cpp:34
+  std::basic_istringstream<CharT> ss(STR(" 123 456"));
+  assert(ss.view() == SV(" 123 456"));
+  ss.str(STR(" 789"));
----------------
Just for completeness, please apply to all tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148641/new/

https://reviews.llvm.org/D148641