[libcxx-commits] [PATCH] D150503: [libc++][PSTL] Make the PSTL submodules only have one header

[Ian Anderson via Phabricator via libcxx-commits]

iana added inline comments.


================
Comment at: libcxx/test/libcxx/lint/lint_modulemap.sh.py:32
                     pass
+                elif re.match(r'^\s*module (?:\w+_)*(\w+)\s+[{] private (textual )?header "__(\w+/)*\1[.]h" [}]', line):
+                    # It's a private pstl submodule, such as <__algorithm/pstl_backends/cpu_backend.h>
----------------
iana wrote:
> This isn't a perfect regex, it's only matching backend.h instead of cpu_backend.h. It's probably ok enough?
It's also about to not matter because the private submodules are going to be generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150503/new/

https://reviews.llvm.org/D150503