[libcxx-commits] [PATCH] D145183: [libc++] Implement `stop_token`

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 12 09:20:40 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/include/__stop_token/stop_state.h:34
+  __callback_fn_t* __callback_fn_;
+  std::atomic<bool> __completed_ = false;
+};
----------------
Here I think we do need to store a pointer to a bool saying whether we've been destroyed to handle https://eel.is/c++draft/thread.stoptoken#stopcallback.cons-6 like we've discussed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145183/new/

https://reviews.llvm.org/D145183



More information about the libcxx-commits mailing list