[libcxx-commits] [PATCH] D145807: [libcxx] [test] Print the failing commands in Configuration{Compilation, Runtime}Error

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/utils/libcxx/test/dsl.py:233
     if exitCode != 0:
      raise ConfigurationRuntimeError()
     return out
----------------
ldionne wrote:
> ldionne wrote:
> > We can do better here. Let's do something like:
> > 
> > ```
> > raise ConfigurationRuntimeError("Failed to run command: {}\nstderr is:\n{}", ...)
> > ```
> @mstorsjo It looks like this comment and the one below were not addressed before landing, do you think you could have a look?
Oh, you're absolutely right - I'm sorry about that! I'll make sure to follow up on this soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145807/new/

https://reviews.llvm.org/D145807