[libcxx-commits] [PATCH] D150284: [libc++][PSTL] Add a simple std::thread backend

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I think this LGTM w/ CI passing. I'd like to see again once rebased and passing though.



================
Comment at: libcxx/include/__algorithm/pstl_backends/cpu_backends/thread.h:20
+
+#include <cassert>
+
----------------
`__assert` instead, and put this above with the other includes.


================
Comment at: libcxx/include/__algorithm/pstl_backends/cpu_backends/thread.h:51
+  }
+  assert(__first == __last);
+
----------------
`_LIBCPP_ASSERT`


================
Comment at: libcxx/include/__config:1274-1275
 
 // TODO: Make this a proper configuration option
 #define _PSTL_PAR_BACKEND_SERIAL
 
----------------
Do we still need this? If not let's remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150284/new/

https://reviews.llvm.org/D150284