[libcxx-commits] [PATCH] D145691: [libc++] Adjust tests using ext/* headers that undefine __DEPRECATED

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 10 13:08:15 PDT 2023


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM. I have no love for these headers and I appreciate the cleanup. I have a small suggestion though.



================
Comment at: libcxx/test/libcxx/extensions/hash/specializations.pass.cpp:11
 
 // NOTE: Undefined __DEPRECATED to prevent this test from failing with -Werror
+// ADDITIONAL_COMPILE_FLAGS: -Wno-deprecated
----------------
This comment is not desirable anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145691/new/

https://reviews.llvm.org/D145691



More information about the libcxx-commits mailing list