[libcxx-commits] [PATCH] D147046: [libc++] Add lit feature for std::signal

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 10 12:57:33 PDT 2023


ldionne added a comment.

I am sad to have missed this! This is actually something we run into internally on some configurations as well, and having this would simplify our lives. As with any such configuration, it's always hard to determine whether it's worth upstreaming or keeping downstream, however I wouldn't be surprised if that were a fairly common one. To do things consistently, however, we'd need to also add a buildbot that runs without signals and hence probably introduce a `LIBCXX_HAS_NO_SIGNALS` setting similar to `LIBCXX_HAS_NO_LOCALIZATION` and friends. I'm not sure that pulls its weight, but I'd be happy to review something like that to evaluate it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147046/new/

https://reviews.llvm.org/D147046



More information about the libcxx-commits mailing list