[libcxx-commits] [PATCH] D147356: Fixing conflicting macro definitions between curses.h and the standard library.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM w/ comment and green CI.



================
Comment at: libcxx/test/libcxx/nasty_macros.compile.pass.cpp:146
+// Test to make sure curses has no conflicting macros with the standard library
+#ifndef refresh
+# define refresh NASTY_MACRO
----------------
You can just define all of those unconditionally since there's no header included before. Essentially we know the `#ifndef` is always true right now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147356/new/

https://reviews.llvm.org/D147356