[libcxx-commits] [PATCH] D149092: [libcxxabi] define _LIBCPP_VERBOSE_ABORT

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

I think this patch shows that in reality, libc++abi should be part of libc++ (i.e. it should be possible to either use an external ABI library, or libc++'s own ABI library aka libc++abi). This is a recurring cause of issues.

Anyway, I think the patch in its current form makes sense, I remember hitting this issue in a different setting and it's indeed kind of unsettling. Thanks for trying to keep the two demangler copies in sync -- that's actually another thing that we should really try to have one canonical version of.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149092/new/

https://reviews.llvm.org/D149092