[libcxx-commits] [PATCH] D150015: [libc++] Consistently enable __CORRECT_ISO_CPP_WCHAR_H_PROTO in mbstate.

[Jordan Rupprecht via Phabricator via libcxx-commits]

rupprecht marked an inline comment as done.
rupprecht added a comment.

Sadly, when I commented out the fix & ran it through CI, the only failure was on the "no wide characters" bot because I didn't have the right XFAIL line for that. I guess we don't have any bots with an old enough glibc?

I accidentally uploaded two tests with the same include ordering, but they both should have caused a test failure. I'm going to run it through one more time to see if a second CI run catches it, and then I'll un-comment the fix.



================
Comment at: libcxx/test/std/strings/c.strings/cwchar_include_order1.compile.verify.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
ldionne wrote:
> I think linking to the bug report somewhere in the tests would be great!
I didn't have one filed yet, so I created https://llvm.org/PR62638 and linked it here for context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150015/new/

https://reviews.llvm.org/D150015