[libcxx-commits] [PATCH] D148753: [libcxx] convert symbol checker from CMake target to lit test

[David Tenty via Phabricator via libcxx-commits]

daltenty added a comment.

>> And do we really need to track the symbols that we refer to but don't export?



> I'm going to throw the ball to @daltenty to help reach a solid answer on this question. But I'm inclined to say that we don't need to track them.

I was asking myself the same thing when we originally added the ABI list support for AIX. I agree, I don't think we really care too much about imports which aren't exports, they don't really affect the ABI surface of the library.

Not to sure about the history of this filtering business either. Wouldn't removing one of these filtered symbols still constitute an ABI break, so you'd want to know about it regardless?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148753/new/

https://reviews.llvm.org/D148753