[libcxx-commits] [PATCH] D150015: [libc++] Consistently enable __CORRECT_ISO_CPP_WCHAR_H_PROTO in mbstate.

[Jordan Rupprecht via Phabricator via libcxx-commits]

rupprecht added a comment.

In D150015#4332022 <https://reviews.llvm.org/D150015#4332022>, @ldionne wrote:

> Does any existing test fail when we run the test suite with glibc-2.25, or do we need to add a test case for this?

No existing test case that I'm aware of. Let me see if the repro Ray posted can be added to the test suite.

> I think the fix we're looking for is simply to do:
>
>   #ifdef __cplusplus
>   #  define __CORRECT_ISO_CPP_WCHAR_H_PROTO
>   #endif
>   
>   // current if-else chain

You're in luck, that was the original version of this patch :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150015/new/

https://reviews.llvm.org/D150015