[libcxx-commits] [PATCH] D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Tue May 9 11:00:05 PDT 2023

ldionne accepted this revision.
ldionne added a comment.

LGTM w/ a few comments. Feel free to ship once those have been addressed, assuming the other reviewer's comments have been satisfied.

================
Comment at: libcxx/docs/Status/Cxx2bPapers.csv:87
 "`P2517R1 <https://wg21.link/P2517R1>`__","LWG","Add a conditional ``noexcept`` specification to ``std::apply``","July 2022","",""
 "`P2520R0 <https://wg21.link/P2520R0>`__","LWG","``move_iterator`` should be a random access iterator","July 2022","|Complete| [#note-P2520R0]_","17.0","|ranges|"
 "`P2540R1 <https://wg21.link/P2540R1>`__","LWG","Empty Product for certain Views","July 2022","","","|ranges|"
----------------
Can we mark the new LWG issues as resolved in `libcxx/docs/Status/Cxx2bIssues.csv`?

================
Comment at: libcxx/include/__expected/expected.h:1272
+    using _Up = remove_cvref_t<invoke_result_t<_Func>>;
+    static_assert(std::__is_std_expected<_Up>::value, "The result of f() must be a specialization of std::expected");
+    static_assert(
----------------
Here too and a few below. I think you can grep for `std::__is_expected`!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140911/new/

https://reviews.llvm.org/D140911