[libcxx-commits] [PATCH] D132268: [libc++][spaceship] Implement `operator<=>` for `vector`

[Hristo Hristov via Phabricator via libcxx-commits]

H-G-Hristov marked 2 inline comments as done.
H-G-Hristov added a comment.

@Mordante Thank you for the suggestions!



================
Comment at: libcxx/include/__algorithm/lexicographical_compare_three_way.h:37
 // then skips the iterator comparisons inside the loop.
 template <class _InputIterator1, class _InputIterator2, class _Cmp>
 _LIBCPP_HIDE_FROM_ABI constexpr auto __lexicographical_compare_three_way_fast_path(
----------------
Mordante wrote:
> I think it would be better to have the changes to this file and the changes directly related to it in a separate commit.
> 
> If you feel strongly about not doing that, then mention these changes in the commit message.
I agree. I'll do that.


================
Comment at: libcxx/test/std/containers/sequences/vector.bool/compare.three_way.pass.cpp:12
+
+// template<class T, class Allocator>
+//   constexpr synth-three-way-result<T> operator<=>(const vector<T, Allocator>& x,
----------------
Mordante wrote:
> The synopsis should use the synopsis for the `vector<bool>` specialization.
To my understanding there isn't a synopsis specific to `vector<bool>` for `operator<=>`. I added `// class vector<bool>`. I hope that's what you mean. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132268/new/

https://reviews.llvm.org/D132268